Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul qt configuration logic #22

Open
aowen87 opened this issue Feb 26, 2019 · 5 comments
Open

overhaul qt configuration logic #22

aowen87 opened this issue Feb 26, 2019 · 5 comments

Comments

@aowen87
Copy link

aowen87 commented Feb 26, 2019

AX_HAVE_QT, the m4 macro logic module Silo uses to configure Qt, is hugely outdated. We're lucky it even work on some systems. We need to replace this with some simple, configuration logic for Qt.

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 1885
Status: New
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: overhaul qt configuration logic
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 06/19/2014
Due date:
% Done: 0%
Estimated time:
Created: 06/19/2014 08:44 pm
Updated: 09/16/2014 02:25 pm
Likelihood: 3 - Occasional
Severity: 2 - Minor Irritation
Found in version: 4.8
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
AX_HAVE_QT, the m4 macro logic module Silo uses to configure Qt, is hugely outdated. We're lucky it even work on some systems. We need to replace this with some simple, configuration logic for Qt.

Comments:
I've overhauled AX_HAVE_QT, replacing the hacks and heuristics with clean logic to detect Qt 5 and later from $PATH and qmake. My revised version can be found at: https://github.com/alexhenrie/autoconf-archive/branchesI have also submitted the changes for inclusion in the GNU Autoconf Archive. No word yet: http://savannah.gnu.org/patch/?8486If you decide to move away from AX_HAVE_QT entirely, you will have to rewrite tools/silex/Makefile.am as a Qt pro file and invoke qmake during the configuration stage. The Autoconf Archive has accepted my revision of AX_HAVE_QT: http://git.savannah.gnu.org/cgit/autoconf-archive.git/commit/?id=a0ef75b4669fb9b173b1796daf3a72e2195fb1f2

@biagas biagas transferred this issue from visit-dav/visit Mar 21, 2019
@markcmiller86
Copy link
Member

This was updated in 4.11 release

@StefanBruens
Copy link

Can you please update it to the latest version from
https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob;f=m4/ax_have_qt.m4;

The current version does not support a qmake installed under a different name (e.g. qmake-qt5), which is required to make Qt5 and Qt6 co-installable.

@markcmiller86
Copy link
Member

This is less likely. We are adding CMake support and once that is fully functional, we intend to eliminate autoconf support. Have you tried the CMake build of main yet?

@StefanBruens
Copy link

Not yet.

In case you leave autoconf enabled for the next release, can you just import the file from the autoconf repository? That should be trivial, and should not break anything.

@markcmiller86
Copy link
Member

In case you leave autoconf enabled for the next release, can you just import the file from the autoconf repository? That should be trivial, and should not break anything.

Sure thing. I recall doing that last time I released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants