-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLIC/Lumberjack: support formatting RANK_COUNT and RANKS #256
Comments
Hi @white238 -- generally I think I am OK with this. To clarify, the request is to have both Is this correct? |
Yepp.. |
In addition, improve the reporting of which ranks generated the message. See also: #283 |
@white238 @bmhan12 This comment above is particularly relevant right now for switching to SLIC. Would something like what's being suggested above still be possible? |
This should be easy to implement, we just abstained due to the person who asked didn't get around to using SLIC/Lumberjack themselves and it was a breaking change. I can do it. |
Currently Lumberjack only reports the following through SLIC's formatting options "<RANKS_COUNT>: ". It has been requested to be allowed to have more control of this and add both options.
@gzagaris you okay with this? or an alternate idea?
The text was updated successfully, but these errors were encountered: