Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLIC/Lumberjack: support formatting RANK_COUNT and RANKS #256

Closed
white238 opened this issue Jun 9, 2020 · 5 comments · Fixed by #1390
Closed

SLIC/Lumberjack: support formatting RANK_COUNT and RANKS #256

white238 opened this issue Jun 9, 2020 · 5 comments · Fixed by #1390
Assignees
Labels
Lumberjack Issues related to Axom's 'lumberjack' component Reviewed Slic Issues related to Axom's 'slic' component

Comments

@white238
Copy link
Member

white238 commented Jun 9, 2020

Currently Lumberjack only reports the following through SLIC's formatting options "<RANKS_COUNT>: ". It has been requested to be allowed to have more control of this and add both options.

@gzagaris you okay with this? or an alternate idea?

@white238 white238 added Lumberjack Issues related to Axom's 'lumberjack' component Slic Issues related to Axom's 'slic' component labels Jun 9, 2020
@gzagaris
Copy link
Member

Hi @white238 -- generally I think I am OK with this.

To clarify, the request is to have both <RANK_COUNT>, which would print the total number of ranks that generated a log message and <RANKS> which prints the "first" N ranks that logged a particular message, where N is the threshold limit set in Lumberjack.

Is this correct?

@white238
Copy link
Member Author

Yepp..

@rhornung67
Copy link
Member

In addition, improve the reporting of which ranks generated the message. See also: #283

@kennyweiss kennyweiss modified the milestones: FY22 Development, FY23 Development Mar 20, 2023
@rhornung67 rhornung67 modified the milestones: FY23 Development, April 2024 Release Sep 25, 2023
@rhornung67 rhornung67 removed this from the April 2024 Release milestone Jan 8, 2024
@gberg617
Copy link

gberg617 commented Jul 8, 2024

Hi @white238 -- generally I think I am OK with this.

To clarify, the request is to have both <RANK_COUNT>, which would print the total number of ranks that generated a log message and <RANKS> which prints the "first" N ranks that logged a particular message, where N is the threshold limit set in Lumberjack.

Is this correct?

@white238 @bmhan12 This comment above is particularly relevant right now for switching to SLIC. Would something like what's being suggested above still be possible?

@white238
Copy link
Member Author

white238 commented Jul 8, 2024

This should be easy to implement, we just abstained due to the person who asked didn't get around to using SLIC/Lumberjack themselves and it was a breaking change. I can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lumberjack Issues related to Axom's 'lumberjack' component Reviewed Slic Issues related to Axom's 'slic' component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants