use compound vec in bicg IR #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nychiang
commented
May 3, 2023
src/Optimization/hiopKKTLinSys.cpp
Outdated
Comment on lines
2014
to
2025
| dir_ir.getVector(0).copyFrom(*dx_); | ||
| dir_ir.getVector(1).copyFrom(*dd_); | ||
| dir_ir.getVector(2).copyFrom(*dyc_); | ||
| dir_ir.getVector(3).copyFrom(*dyd_); | ||
| dir_ir.getVector(4).copyFrom(*dsxl_); | ||
| dir_ir.getVector(5).copyFrom(*dsxu_); | ||
| dir_ir.getVector(6).copyFrom(*dsdl_); | ||
| dir_ir.getVector(7).copyFrom(*dsdu_); | ||
| dir_ir.getVector(8).copyFrom(*dzl_); | ||
| dir_ir.getVector(9).copyFrom(*dzu_); | ||
| dir_ir.getVector(10).copyFrom(*dvl_); | ||
| dir_ir.getVector(11).copyFrom(*dvu_); |
There was a problem hiding this comment.
the order to build the compound vector is hard-coded. Should we use unordered_map to avoid this? @cnpetra
There was a problem hiding this comment.
It's still a draft PR. If we agree to this implementation, I will clean the code and add some comments.
There was a problem hiding this comment.
the order to build the compound vector is
hard-coded. Should we use unordered_map to avoid this? @cnpetra
I was thinking to use a PrimalDualVector class instead of the so-called compound. It may not covered all the use cases though...
cnpetra
approved these changes
May 26, 2023
cnpetra
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE #630