Use integer preprocessor macros for version information #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not opposed to using integer values and lgtm. It does not trigger any of the CI for some strange reason. Any idea why? |
cnpetra
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend this patch to change the
HIOP_VERSION_MAJOR,HIOP_VERSION_MINOR, andHIOP_VERSION_PATCHfrom string to integer values. As string values, this comparison does not seem to do what I hope it would:#if defined(LIDO_USE_IPOPT) || (defined(LIDO_USE_HIOP) && ((HIOP_VERSION_MAJOR > 0) || (HIOP_VERSION_MAJOR == 0) && ((HIOP_VERSION_MINOR > 7) || ((HIOP_VERSION_MINOR == 7) && (HIOP_VERSION_PATCH >= 1)))))Based on what I've read, changing it to do things like
HIOP_VERSION_MAJOR > "0"won't work either.You don't really lose anything because you can change an integer value into a string using
# LIDO_VERSION_MAJORto changeLIDO_VERSION_MAJORinto a string.