Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPI environment variables to packages #1103

Merged
merged 1 commit into from
Jun 27, 2016

Conversation

adamjstewart
Copy link
Member

This PR solves #991, thanks to the brilliant @alalazo! parallel-netcdf wouldn't build for me with Intel and OpenMPI without these environment variables set. It's probably a good idea to have them in all MPI packages.

@alalazo
Copy link
Member

alalazo commented Jun 23, 2016

@adamjstewart Don't forget to change :

self.spec['mpi'].mpicc # and similar

into

mpicc # an similar

in every package that used the feature. scotch could be a good test case to check that the changes do not actually break compilation.

@davydden
Copy link
Member

@adamjstewart documentation should also be adjusted accordingly.

@adamjstewart
Copy link
Member Author

Oh, is that what that does? I kinda like spec['mpi'].mpicc, it felt less magical and more understandable. I still don't know what spack_cc means, but I see that around various places.

I think I'll back out the second commit since that affects a lot of packages and isn't really the same issue that I'm facing. If someone else wants to create a second PR to set module.mpicc and edit every package and the documentation then they're welcome to do so.

@davydden
Copy link
Member

I kinda like spec['mpi'].mpicc, it felt less magical and more understandable.

+1.

@tgamblin tgamblin merged commit 8b35940 into spack:develop Jun 27, 2016
@adamjstewart adamjstewart deleted the features/mpi branch June 27, 2016 14:57
olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants