Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astyle: fix filter command which failed on OSX with python 2.7.10 #948

Merged
merged 1 commit into from
May 18, 2016
Merged

astyle: fix filter command which failed on OSX with python 2.7.10 #948

merged 1 commit into from
May 18, 2016

Conversation

davydden
Copy link
Member

tested on darwin with clang and ubuntu with gcc4.8.

@davydden
Copy link
Member Author

@tgamblin can you please have a look at this? The current state of astyle is broken.

@adamjstewart
Copy link
Member

How are these different?

@davydden
Copy link
Member Author

i am not a python expert, but i know that the original code did not work for me neither on osx nor on ubuntu.

@tgamblin
Copy link
Member

tgamblin commented May 18, 2016 •
edited
Loading

@adamjstewart: % wants %d, %s, etc. in the string; format() wants {0}, {1}, etc. (or {}, but only in 2.7+)

@tgamblin tgamblin merged commit 637da63 into spack:develop May 18, 2016
@davydden
Copy link
Member Author

here you go, so it could have been 'CXX={0}'.format(spack_cxx)

@adamjstewart
Copy link
Member

Ah, of course. Sorry I missed that. Looks good now.

@davydden davydden deleted the bugfix/astyle branch May 28, 2017 20:57
olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
@ferdonline
Neurodamus bump and implementing stable dependency (spack#948)
b2c0322 
Version bumps:
* Neurodamus-py updated to 2.1.1.
* Neurodamus-core updated to 3.0.2

Logic updates:
* Neurodamus-xxx implementing stable dependency with neurodamus-core
* Neurodamus-xxx version is now made of `<model_v>-<core-v>`
* Neurodamus-model core dependency set to build-only
  Previously the dependency was set to 'run' as well to force updating
  the package whenever core was updated. This no longer applies since
  the core dependency version is now explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davydden @adamjstewart @tgamblin