Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to remove a single user defined unit #271

Closed
jl-wynen opened this issue Jan 9, 2023 · 2 comments · Fixed by #273
Closed

Function to remove a single user defined unit #271

jl-wynen opened this issue Jan 9, 2023 · 2 comments · Fixed by #273

Comments

@jl-wynen
Copy link
Contributor

jl-wynen commented Jan 9, 2023

Given that you are planning to add more features to user defined units as mentioned in #268 (comment), it would be nice for our use case to add the ability to remove a single user defined unit.

Currently, we implement this functionality by clearing all user defined units and re-adding all except the removed one. Performance is not curial for us, so it works fine. But I would expect other users to face a similar problem.

@phlptp
Copy link
Collaborator

phlptp commented Jan 9, 2023

Noted: I will look into it shortly. Thanks for the suggestion

@phlptp phlptp linked a pull request Jan 17, 2023 that will close this issue
@jl-wynen
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants