Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build when '/usr/bin/fluid' is not available #954

Closed
raboof opened this issue Jul 8, 2014 · 12 comments
Closed

Fails to build when '/usr/bin/fluid' is not available #954

raboof opened this issue Jul 8, 2014 · 12 comments

Comments

@raboof
Copy link
Contributor

raboof commented Jul 8, 2014

Not caught by 'cmake', but encountered on 'make':

[ 94%] Building CXX object plugins/zynaddsubfx/CMakeFiles/ZynAddSubFxCore.dir/zynaddsubfx/src/Synth/SUBnote.o
Linking CXX shared library libZynAddSubFxCore.so
[ 94%] Built target ZynAddSubFxCore
make[2]: *** No rule to make target `/usr/bin/fluid', needed by `plugins/zynaddsubfx/zynaddsubfx/src/UI/VirKeyboard.h'.  Stop.
make[1]: *** [plugins/zynaddsubfx/zynaddsubfx/src/UI/CMakeFiles/zynaddsubfx_gui.dir/all] Error 2
make: *** [all] Error 2

Easily fixed by 'sudo apt-get install fluid', but should've been caught earlier

@raboof raboof changed the title Fails to build when 'fluid' is not available Fails to build when '/usr/bin/fluid' is not available Jul 8, 2014
@diizy
Copy link
Contributor

diizy commented Jul 8, 2014

On 07/08/2014 08:50 PM, Arnout Engelen wrote:

Not caught by 'cmake', but encountered on 'make':

|[ 94%] Building CXX object plugins/zynaddsubfx/CMakeFiles/ZynAddSubFxCore.dir/zynaddsubfx/src/Synth/SUBnote.o
Linking CXX shared library libZynAddSubFxCore.so
[ 94%] Built target ZynAddSubFxCore
make[2]: *** No rule to make target /usr/bin/fluid', needed byplugins/zynaddsubfx/zynaddsubfx/src/UI/VirKeyboard.h'. Stop.
make[1]: *** [plugins/zynaddsubfx/zynaddsubfx/src/UI/CMakeFiles/zynaddsubfx_gui.dir/all] Error 2
make: *** [all] Error 2
|

Did you have Fluidsynth installed when trying to build?

@raboof
Copy link
Contributor Author

raboof commented Jul 8, 2014

Indeed installing fluid fixed the issue, I just expected that to be checked by cmake, not make... not a big deal I guess :)

@diizy
Copy link
Contributor

diizy commented Jul 8, 2014

On 07/08/2014 10:59 PM, Arnout Engelen wrote:

Indeed installing fluidsynth fixed the issue, I just expected that to
be checked by cmake, not make... not a big deal I guess :)

Oh ok... should be fixable then, someone just has to edit the cmake
script...

@tobydox
Copy link
Member

tobydox commented Jul 9, 2014

/usr/bin/fluid has nothing to do with fluidsynth. It's the code generator tool of FLTK which creates C files from FL files. If you properly installed FLTK development packages fluid should be part of it already. If not, the dependencies of your distribution probably are a bit too loose.

@raboof
Copy link
Contributor Author

raboof commented Jul 9, 2014

In Debian fluid and libfltk1.3-dev are packaged separately, indeed no dependency between the two.

@tresf
Copy link
Member

tresf commented Jul 9, 2014

@raboof,

Since this is a Debian upstream packaging bug I would recommend filing a bug upstream (if so inclined) and closing this one out.

Thanks for the detailed bug report. I look forward to seeing more!

@diizy
Copy link
Contributor

diizy commented Jul 10, 2014

Eh, yeah, I meant the FLTK thing, no idea why I said Fluidsynth (except that both contain the word "fluid").

Anyway, if this is a Debian issue, then this report can probably be closed?

@raboof
Copy link
Contributor Author

raboof commented Jul 10, 2014

The Debian 'libfltk1.3-dev' package does 'Recommend' the fluid package, but does not require it.

That sounds kind of reasonable, as after processing the fl's you don't need fluid anymore, but you do need libfltk1.3-dev.

I won't create a bugreport against Debian for this, but I also don't feel so strongly about it, so if you don't find it worth the effort you're welcome to close this issue.

@davidgerard
Copy link

It'd be nice if we could at least spot it in some reasonable fashion though (even a note in INSTALL or something) - this one keeps biting people. It even bites me when I'm compiling on a fresh box and I always go "oh yeah ..."

@Sti2nd
Copy link
Contributor

Sti2nd commented Sep 23, 2014

Always read the instruction, I guess? https://github.com/LMMS/lmms/wiki/Compiling-lmms

@tresf
Copy link
Member

tresf commented Sep 23, 2014

Always read the instruction, I guess?

It was never in the instructions because we never told people to install this.

But this bug report is a bit more fundamental. The OP is asking for inclusion into our CMakeLists.txt file which does the sanity checks prior to build. It's more a matter of where this bug resides -- in a Debian package, or in our build script. Since the OP didn't feel this warranted a bug upstream, we chose neither because of Toby's words:

If you properly installed FLTK development packages fluid should be part of it already. If not, the dependencies of your distribution probably are a bit too loose.

Unfortunately, this "distribution" (Debian) is the upstream of many, many distributions so if we don't fix it upstream, it's only going to happen more and more.

So as an interim solution, I've added a line item to the wiki, which should fix this for most people following our build instructions until a permanent decision can be made. 🌵

@tobydox
Copy link
Member

tobydox commented Sep 28, 2014

Ok, we should add a check for fluid then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants