Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up conditional dependency on pandas for py 3.7 #21

Closed
heather999 opened this issue Feb 22, 2022 · 0 comments
Closed

Set up conditional dependency on pandas for py 3.7 #21

heather999 opened this issue Feb 22, 2022 · 0 comments

Comments

@heather999
Copy link
Contributor

I have a simple PR open on qp: LSSTDESC/qp#73 that just removes astropy from the list of dependencies - since it is truly no longer a dependency. Unfortunately the tests against py3.7 fail as the qp setup installs tables_io which installs pandas.
The recent pandas releases since 1.4.x have dropped support for python 3.7.
While I wondered aloud about dropping support for 3.7 - given that python 3.7 is still alive for now and clearly still supported on conda-forge, I'd like to suggest modifying the requirements and setup.py in this repo to conditionally restrict the version of pandas if we're dealing with python 3.7, otherwise, there should be no restrictions.
I think I can muster a PR to make that happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant