Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mplot #108

Merged
merged 68 commits into from
Jan 21, 2024
Merged

Mplot #108

merged 68 commits into from
Jan 21, 2024

Conversation

LSYS
Copy link
Owner

@LSYS LSYS commented Jan 21, 2024

No description provided.

Preparing example data for plotting 'Multiple forestplots'. Where each row in the table/plot has multiple coefficients from multiple models.
- Additional reorganizing of forestplot/mplot.py neede
d.

- Tests needed.

Docstrings needed.
* Allow no drawing of CI (#61)

* Allow no drawing of CI (#58)

* Update CI.yml

* Update nb.yml

* Update options (#58)

* Increase images

* Bump to v0.3.0 (#58)

* Patch (#68)

* Update branches in workflows
* Replacing append with concat in Pandas (#66)
Utils split into two other files specific to mplot.
Pytest showing nan==nan as error for py3.9 and py3.10.
* Troubleshooting workflow error (#87)

Pytest showing nan==nan as error for py3.9 and py3.10.

* Add branch to workflow (#88)

* Testing make_multimodel_tableheaders (#88)

* Add test_make_multimodel_tableheaders (#88)

* Pleasing linters (#88)

* Add docstring & test for  (#88, #89)

* Fix compatibility with newer mpl versions (#82)

* Pleasing linters

* Pleasing linters
* Add docstring & test for mdraw_yticklabel2 (#88, #89)

* Pleasing linters

* Pleasing linters
* Add docstring & test for mplot (#88, #89)

* Pleasing linters
Move xrefline to zorder=0
* Add option to remove mplot legend

* Pleasing linters
* Fix model to model_col

Without this fix, there will be weird result if the model column has some other name than 'model'.

* Bump to ver 0.4.0
* Update readme for mplot (#99)
* Bump version to 0.4.0
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d362bc5) 96.95% compared to head (6f4baf0) 96.90%.

Files Patch % Lines
forestplot/mplot_graph_utils.py 91.00% 9 Missing ⚠️
forestplot/mplot.py 97.14% 2 Missing ⚠️
forestplot/graph_utils.py 66.66% 1 Missing ⚠️
forestplot/mplot_dataframe_utils.py 98.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   96.95%   96.90%   -0.05%     
==========================================
  Files          11       17       +6     
  Lines        1083     1421     +338     
==========================================
+ Hits         1050     1377     +327     
- Misses         33       44      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 21, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@LSYS LSYS merged commit 04b8858 into main Jan 21, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant