add wheel to build, include a requirements_dev.txt and document #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 11 11
Lines 1070 1070
=======================================
Hits 1046 1046
Misses 24 24 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LSYS
reviewed
Oct 31, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wheel to the build command so that that pypi will have a wheel instead of just a source package; fixes #32.
To build a wheel, I needed to pip install the wheel package, but didn't find a consistent place to put this. Therefore, I added a
requirements_dev.txtfile and documented its use. Its more than you were asking for with this PR, but I think it'll make it easy to more consistently add developer requirements.