Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a wheel to pypi in addition to a tar.gz file #32

Closed
shapiromatron opened this issue Oct 25, 2022 · 3 comments · Fixed by #35
Closed

add a wheel to pypi in addition to a tar.gz file #32

shapiromatron opened this issue Oct 25, 2022 · 3 comments · Fixed by #35

Comments

@shapiromatron
Copy link
Contributor

shapiromatron commented Oct 25, 2022

Got an install warning:

DEPRECATION: forestplot is being installed using the legacy 'setup.py install' method, 
because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 
23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-
pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

It would be good to also push wheels to pypi; since this package is pure python it should be fairly straightforward. I would be happy to contribute to a PR if you would accept.

@LSYS
Copy link
Owner

LSYS commented Oct 28, 2022

@shapiromatron thanks for raising this issue.
Is this what you get after doing a pip install forestplot?

I don't seem to be getting this error. Let me investigate a little too.

@shapiromatron
Copy link
Contributor Author

Yes, but I didn't have the wheel package installed. It think when you make a release, you'll want to build a wheel in addition to a tar.gz. I think you just need to add bdist_wheel to this line:

@python setup.py sdist

@LSYS
Copy link
Owner

LSYS commented Oct 30, 2022

Can you make a PR for this?
But I'm not sure whether we should merge with main or patch. I'm making some changes for the next version from patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants