Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FrontEnd more efficient #23

Open
billbrod opened this issue Jan 29, 2020 · 2 comments
Open

Make FrontEnd more efficient #23

billbrod opened this issue Jan 29, 2020 · 2 comments

Comments

@billbrod
Copy link
Collaborator

The FrontEnd model is a very useful one, and would be great to have in some examples, but it's right now so inefficient that synthesizing with it is very slow. How can we make it more efficient?

Discussed a bit with @pehf and my understanding is the main issue is that it's convolving with 31x31 kernels in the signal domain (I haven't profiled it to investigate). If that's so, will get slower as a function of image size. Could we not just take the Fourier transform of the kernel and the image, multiply together, and take the inverse Fourier transform (like the way our steerable pyramid implementation works)?

@lyndond
Copy link
Collaborator

lyndond commented Apr 6, 2021

The frontend model(s) in #95 now address this because they can have arbitrary kernel sizes. These convs are still done in spatial domain and not frequency domain, but I think that's now ultra-low priority.

@billbrod
Copy link
Collaborator Author

billbrod commented Apr 6, 2021

agreed that a faster / frequency implementation is very low priority, but I'd like to see that synthesized images with smaller kernel sizes are qualitatively similar before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants