Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of a DictFeat, LabeledFeatWidget._widget doesn't have a value_to_feat method and communication fails #65

Open
thibaudruelle opened this issue Apr 20, 2016 · 0 comments

Comments

@thibaudruelle
Copy link

Context: I ran start_test_app on an instance of a custom driver which contained a DictFeat and clicked on its set button. The following error shows up after closing the Test Panel:

Traceback (most recent call last):

  File "C:\Anaconda3\lib\site-packages\lantz\ui\widgets.py", line 470, in on_set_clicked
    self._widget.value_to_feat()

AttributeError: 'DictFeatWidget' object has no attribute 'value_to_feat'

Note that there is no runtime error since the value_to_feat method is never called (see Issue "In case of DictFeat, DriverTestWidget.update_on_change() has no effect").

Probable origin: In case of a DictFeat, LabeledFeatWidget._widget is a DictFeatWidget, which doesn't have a value_to_feat method.

Probable fix: add the value_to_feat method to DictFeatWidget

Proposed fix: add to DictFeatWidget

def value_to_feat(self):
        return self._value_widget.value_to_feat()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant