Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Profiles for map mod highlighting #384

Closed
worldendDominator opened this issue May 16, 2024 · 5 comments
Closed

[Suggestion] Profiles for map mod highlighting #384

worldendDominator opened this issue May 16, 2024 · 5 comments

Comments

@worldendDominator
Copy link

Let us save multiple sets of map mod highlights for different characters. There's already a similar feature for item mods, after all.

@Lailloken
Copy link
Owner

Hmm, I thought about it in the past and decided against it, but we can certainly discuss it. I don't remember every reason against it, but here are a few:

  • the structure I used for saving the config would need to be revamped to allow for profiles, and the current config would have to be converted through an update (not a big deal, I would just have to get over my laziness)

  • it feels like almost 75% of map mods would have the same tiering/highlighting across all of the profiles anyway (area mods, monster-type mods, etc.)

    • feel free to provide exceptions, I'm sure some mods are escaping my mind right now
  • I thought there's only a hand-full of mods that can completely brick a map for certain builds

    • the intention was to mark them as tier/difficulty 4 for all builds, then use the cross-out feature to mark them safe/unsafe for individual builds

    • I recently added a mod-search to the settings to facilitate changing brick-mods in bulk, in case the T4/cross-out system was not preferred

While writing this, I had an alternative idea: I could add a section to the settings menu with "pinned" map-mods whose tiering/highlighting can be changed on the fly. The obvious default ones would be reflect, no regen, no leech, stun-immune, etc., and I would add a button to the results in the search-box so that the user can pin additional mods. That would get around the issue of that ~75% mod-pool that's the same across all profiles.

Let me know what you think.

@worldendDominator
Copy link
Author

I wasn't aware of the mod search feature. It looks rather useful for this. But the idea of a settings section sounds even better since the mods are immediately in front of you and you don't have to remember which ones you need.

@Lailloken
Copy link
Owner

Here's how it turned out for now, and I'm pretty happy with it.

These five mods are pinned by default:
image

And when you search for something, it looks like this:
image

Unless there's more you want included, this will be added to the next release.

@worldendDominator
Copy link
Author

Looking good!

@Lailloken
Copy link
Owner

v1.53.3 is now online. You can close this thread once you've tested the additions and feel everything's working as it should.
Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants