Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe conflict with Consistency+ #39

Open
magneticflux- opened this issue Nov 8, 2022 · 5 comments · May be fixed by #41
Open

Recipe conflict with Consistency+ #39

magneticflux- opened this issue Nov 8, 2022 · 5 comments · May be fixed by #41

Comments

@magneticflux-
Copy link

C+ adds stone to the stone_crafting_materials tag, which results in the recipe for "Sturdy Stone" replacing the vanilla recipe for stone bricks. I reported this here instead of to C+ since it seems like this was a misuse of the stone_crafting_materials tag to mean "cobblestone and blackstone" when those should probably be explicitly stated. I recommend using #c:cobblestone instead.

@LambdAurora
Copy link
Owner

stone_crafting_materials is used for crafting pickaxes or furnaces

Stone being added to it is weird imo

@magneticflux-
Copy link
Author

Idk, not being able to craft a stone pickaxe with stone is also kinda weird lol

@LambdAurora
Copy link
Owner

My bad, the tag is used for the furnace and the brewing stand.

Them adding stone to the tag is a strange decision to me.

@magneticflux-
Copy link
Author

magneticflux- commented Dec 10, 2022

It was added in this commit ConsistencyPlus/ConsistencyPlus@d79da7b#diff-4a47d44272e73934e791429440f7b6c3937911cf2ba21cca43ca2208c991ab73, so we could just ask @Cart3r1234 for clarification.

@Cart3r1234
Copy link

Cart3r1234 commented Dec 11, 2022

The intention was to allow crafting stone-based recipes (including tools; we do modify both tags) with any block type considered a stone (stone, andesite, diorite, granite, tuff, dripstone, calcite, deepslate, blackstone, and for some reason basalt) following Mojang allowing crafting stone items out of blackstone and deepslate, however we were unaware that this is what caused that recipe conflict.

At some point I would like to try and knock out as many C+/AD conflicts as possible, although I'm not too sure how we'd go about doing that. A lot of the same blocks are added by both of our mods, and there are quite a few identical recipes. Identical recipes involving vanilla blocks would be the real challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants