Document making sure the public disk is properly configured

[tabacitu]

In order to get it working, I had to change the configured public disk, from:

        'public' => [
            'driver'     => 'local',
            'root'       => public_path(),
            'visibility' => 'public',
        ],

to

        'public' => [
            'driver' => 'local',
            'root' => storage_path('app/public'),
            'url' => env('APP_URL') . '/storage',
            'visibility' => 'public',
            'throw' => false,
        ],

(which is what Laravel 10 ships with). Before that... the bassets incorrectly got saved to public/bassets instead of storage/app/public/bassets.

My question here is... my configuration was wrong... right? I was using the Demo... the Demo had a very (VERY) old version of the config file... so it was wrong... it wasn't taking into account that people do php artisan storage:link nowadays, correct? So it's not something we should be fixing... But it may be something we'd want to document... in a troubleshooting guide, or something like that. Because I expect people will stumble into this.

Or even as a first installation step (for Bassets), we could tell people to check that their public disk is properly configured and looks like X.

[promatik]

Hey @tabacitu!

I was checking, and our demo project is a dinossaur 🦖
The changes required were introduced in Laravel v7.

https://github.com/laravel/laravel/blob/6.x/config/filesystems.php#L39
https://github.com/laravel/laravel/blob/7.x/config/filesystems.php#L39

Should we add anything regarding this to the docs anyway?
Or can we assume no one is going to have the same problem?

[tabacitu]

I still think people might stumble into this, so yes let's document it in the README, perhaps we can create a Troubleshooting section or something. If we were running with a config file that old... I'm sure someone somewhere is doing the same 😅

[promatik]

@tabacitu added a small note here: #34