Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ rules other than @media break CSS import #245

Closed
lpaulsen93 opened this issue Jun 15, 2019 · 1 comment
Closed

@ rules other than @media break CSS import #245

lpaulsen93 opened this issue Jun 15, 2019 · 1 comment
Labels

Comments

@lpaulsen93
Copy link
Owner

The ODT plugin's CSS parser fails to import @ rules other than @media.

This e.g. leads to broken CSS import if the edittable plugin is installed and enabled. The edittable plugin uses CSS code for animations and this use other @ rules (@keyframes, also see https://www.w3schools.com/css/css3_animations.asp).

Having a broken CSS import means that a lot of CSS styles are simply lost and cannot be used on ODT export. E.g. right now if a user exports a page to ODT with wrap boxes in it and the edittable plugin is installed then the export of the wrap boxes is broken. The wrap boxes do not show any colors and images are missing.

@lpaulsen93
Copy link
Owner Author

This has been fixed in 2c1d563.

lpaulsen93 added a commit that referenced this issue Jun 15, 2019
- parse all '@something' rules properly, not only '@media' rules. Fixes #245.
- fixed missing media selector for '.less' files (e.g. '@media print' for 'print.less')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant