This repository has been archived by the owner on Jan 29, 2018. It is now read-only.
Remove unnedded G1 commands #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G1 is assumed in all controllers I'm aware of, if it's the last command. This should help some with the serial issues.
Optimization: Remove unneccessary G1 commands
|
Does this take firmwares into accounts where G1 = laser full on?
We have it in LW4 as an option that you can tick : "Burn White" which
makes white moves G1 S0 moves. But in LW3 just replacing as is, could have
impact on machines where G1 = laser full on (for example smoothie, if S
hasnt been specified, may default to 80% power)
Some things are done the way they are, because over the year of development
it was done the way they are because there was a reason...
…On Tue, Jan 31, 2017 at 8:02 PM, james-lan ***@***.***> wrote:
As there are some serial issues, this optimization removes any G1 commands
that are not necessary from the laserraster.js output, via keeping track of
the last command.
It probably won't help a huge amount, but that's 2 bytes on almost every
line of the raster output, which should help some.
------------------------------
You can view, comment on, or merge this pull request online at:
#228
Commit Summary
- Optimization: Remove unneccessary G1 commands
- Merge pull request #1 from james-lan/Extra-G1-Removal
File Changes
- *M* public/js/laserraster.js
<https://github.com/LaserWeb/LaserWeb3/pull/228/files#diff-0> (20)
Patch Links:
- https://github.com/LaserWeb/LaserWeb3/pull/228.patch
- https://github.com/LaserWeb/LaserWeb3/pull/228.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#228>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr27AS99ygvr6sgQRJSccZVXwE24nBks5rX3c4gaJpZM4Ly93n>
.
|
|
This breaks smoothieware buffer streaming! For smoothie, we concatenate multiple G0/G1 commands in one line of up to 64 bytes without \n between the commands (because smoothie can separate commands by the Gx). |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are some serial issues, this optimization removes any G1 commands that are not necessary from the laserraster.js output, via keeping track of the last command.
It probably won't help a huge amount, but that's 2 bytes on almost every line of the raster output, which should help some.