Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #1

Merged
merged 24 commits into from
Jul 17, 2018
Merged

Dev #1

merged 24 commits into from
Jul 17, 2018

Conversation

Lauszus
Copy link
Owner

@Lauszus Lauszus commented Jul 16, 2018 •
edited
Loading

  • Convert into Python package
  • Improved tests
  • Improved CANopen false positive when parsing the messages
  • Now works on Windows
  • Support pypy and pypy3

@Lauszus
Determine the node ID string after the function code, so it is not in…
a0af6f4 
…correctly set
@Lauszus
Added code for automatically converting the raw bytes by using the st…
02fbcd9 
…ruts package
@Lauszus
Convert into Python package and use pytest for testing
fe33f82
@Lauszus
Remove the sorting argument, as it is no longer necessary
16001cd
@Lauszus
Disable parallel builds, as test_receive is relying on test_canopen
52eec7d
@Lauszus
Added missing headers and setup.py entires
d093a8c
@Lauszus
Parsed values were not shown if the data was not iterable fx a single…
a277cd7 
… int
@Lauszus
Readded the sorting argument, as the count should not be incremented …
7bf01dc 
…when sorting

Also replaced list in each id with a dict
@Lauszus
Define the CANopen function code in init
b4348c5
@Lauszus
Validate the node ID in the NMT message as well
d64d309
@Lauszus
Added tests for pack_data and unpack_data
f9e87e1
@codecov
Copy link

codecov bot commented Jul 16, 2018 •
edited
Loading

Codecov Report

Merging #1 into master will increase coverage by 4.96%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master     #1      +/-   ##
========================================
+ Coverage   95.03%   100%   +4.96%     
========================================
  Files           2      2              
  Lines         161    155       -6     
  Branches       28     42      +14     
========================================
+ Hits          153    155       +2     
+ Misses          1      0       -1     
+ Partials        7      0       -7
Impacted Files Coverage Δ
python_can_viewer/__init__.py 100% <100%> (ø)
python_can_viewer/python_can_viewer.py 100% <100%> (ø)

@Lauszus Lauszus force-pushed the dev branch 3 times, most recently from cd2c3ef to 1cd87eb Compare July 16, 2018 22:00
@Lauszus Lauszus force-pushed the dev branch 3 times, most recently from 7fc94b4 to cc93a22 Compare July 16, 2018 22:27
@Lauszus Lauszus force-pushed the dev branch 3 times, most recently from db89dd0 to cdb6c6f Compare July 17, 2018 01:13
@Lauszus Lauszus merged commit 62c965e into master Jul 17, 2018
@Lauszus Lauszus deleted the dev branch July 17, 2018 15:08
@Lauszus Lauszus mentioned this pull request Jul 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Lauszus