Added support for PCAN on Mac

[Lauszus]

I had to change the ID from c_uint to c_ulong, as it caused a "Segmentation fault: 11"

Driver can be found here: http://www.mac-can.com

[Lauszus]

FYI I have been using it with my small CAN viewer terminal application: https://github.com/Lauszus/python_can_viewer.

[felixdivo]

Great! This should also be documented in /doc/iterfaces/pcan.rst before merging.

[felixdivo]

Do you work more often with the PEAK systems and have time to address #56 as well? It is an old issue and nobody seems to pick it up.

[codecov]

Codecov Report

Merging #365 into develop will increase coverage by 0.03%.
The diff coverage is 58.33%.

@@             Coverage Diff             @@
##           develop     #365      +/-   ##
===========================================
+ Coverage    59.31%   59.34%   +0.03%     
===========================================
  Files           55       55              
  Lines         4242     4243       +1     
===========================================
+ Hits          2516     2518       +2     
+ Misses        1726     1725       -1

[Lauszus]

@felixdivo just updated the PCAN documentation. Also made PCAN_USBBUS1 the default channel.

[felixdivo]

You could just put channel = 'PCAN_USBBUS1' in the formal parameter list of __init__() and then remove lines 91-94. The same goes for bitrate as well AFAIK. We would have to re-add it in the super().__init__() call at the end though. Example code.

[felixdivo]

Thanks for the additions! Do you know what devices are supported by the backend? That would make the docs quite complete for now. 😄

[Lauszus]

@felixdivo I have added the suggested changes. I have only tested it with PCAN-USB, as that is the only one I have available.

[Lauszus]

Btw I have tested it on Mac and Windows. Will test on Linux asap.

[felixdivo]

Nice, thank you!

[Lauszus]

I have updated the documentation, as the PCAN adapters are actually supported by the kernel >= 3.4.

[felixdivo]

Good addition, although the new section would better fit in the socketcan section.

[Lauszus]

@felixdivo please see: eb9640f. I have added this as well, so it will use the default channel for the interface if channel is None.

I will fix the documentation in the coming days (I'm on vacation atm).

[Lauszus]

@felixdivo may I suggest you add a codecov.yml file were you set the threshold, so codecov does not fail for very small thresholds. You can check out this for for an example: https://github.com/Lauszus/python_can_viewer/blob/master/codecov.yml. This also allow you to make the codecov comment way smaller: Lauszus/python_can_viewer#1 (comment).

[felixdivo]

See #372

[Lauszus]

I have updated the documentation in 5a4868e.

[felixdivo]

Yes, looks good now! Shall I merge it like that?

[christiansandberg]

The basic.py file comes from Peak and we try to keep it up to date. So if we make our own modifications then we need to make clear comments in the code why it has been modified. Otherwise someone will update it to a newer version in the future and the changes will be lost since they will think that the previous version was probably wrong.

[Lauszus]

@christiansandberg fixed in 958f57c.

[felixdivo]

We could also notify PEAK of the fix.

[Lauszus]

It's part of the Mac PCAN basic driver, so they must be aware of it.

[felixdivo]

Shall I merge it our do you still have some pending changes?

[Lauszus]

435ac1b fixes a bug, as the millis_overflow value was not used when calculating the timestamp. This has not been tested, but I will be able to test it in a week or two.

[Lauszus]

I just tested this on both Mac and Windows and it should be good to merge :)