Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V8] RN 0.66.5 + SES 0.18.1: 31 warnings #14

Closed
leotm opened this issue Mar 6, 2023 · 1 comment
Closed

[V8] RN 0.66.5 + SES 0.18.1: 31 warnings #14

leotm opened this issue Mar 6, 2023 · 1 comment
Labels
android iOS lockdown promise Promise polyfill v8 Chrome V8 warning build/runtime remaining successful

Comments

@leotm
Copy link
Member

leotm commented Mar 6, 2023

Follow-up to


RN Remote Debugging

Screenshot 2023-03-01 at 12 22 52

Screenshot 2023-03-01 at 12 24 02

Tolerable as we have a fully functioning RN app
These can be ignored via RN's internal LogBox

Or worst-case omit our RN Promise polyfill, then testing meta-maskmobile

Ideal result: Include RN Promise polyfill (or other) with 0 warnings

Not a blocker in RN, unless proves in metamask-mobile (i.e. fuller RN repo's)

@leotm leotm changed the title RN 0.66.5 + SES 0.18.1 + iOS + V8: Promise warnings RN 0.66.5 + SES 0.18.1 + Android/iOS + V8: Promise warnings Mar 9, 2023
@leotm leotm changed the title RN 0.66.5 + SES 0.18.1 + Android/iOS + V8: Promise warnings RN 0.66.5 + SES 0.18.1: Promise warnings Mar 12, 2023
@leotm leotm added the warning build/runtime remaining successful label Mar 12, 2023
@leotm leotm changed the title RN 0.66.5 + SES 0.18.1: Promise warnings RN 0.66.5 + SES 0.18.1: 31 warnings Mar 12, 2023
@leotm leotm added lockdown promise Promise polyfill labels Mar 15, 2023
@leotm leotm changed the title RN 0.66.5 + SES 0.18.1: 31 warnings [V8] RN 0.66.5 + SES 0.18.1: 31 warnings Apr 17, 2023
@leotm
Copy link
Member Author

leotm commented Jul 7, 2023

closing as these warnings are expected

the 20 Promise warnings are tracked in

all warnings are mentioned in

discussing console warnings next endo weekly sync 12/7/23

specifics on these 11 V8 non-standard intrinsics can be dived into if necessary

@leotm leotm closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android iOS lockdown promise Promise polyfill v8 Chrome V8 warning build/runtime remaining successful
Projects
None yet
Development

No branches or pull requests

1 participant