chore: deprecate earningsReceiver #562
Conversation
| require( | ||
| _operatorDetails[msg.sender].earningsReceiver == address(0), | ||
| "DelegationManager.registerAsOperator: operator has already registered" | ||
| ); |
There was a problem hiding this comment.
I think we should default to setting the value of this deprecated field to zero.
We dont need to keep this require here, but if we plan to repurpose this field later, we need to make sure people aren't already setting it to a nonzero value.
There was a problem hiding this comment.
it has already been set to a nonzero value by all existing users 😞
one option I suggested was setting it to the operator's own address, but I think setting it to zero could also be fine.
There was a problem hiding this comment.
Since all existing registered operators have nonzero values I thought its best to not make assumptions on whatever value this field is and let it be whatever people have it set to.
If we use this field later, we need to allow for a period for operators to update it and then assume afterwards that it's configured.
There was a problem hiding this comment.
ah right i missed that we currently require this to be nonzero. yikes!
if we use this field later... we could do that or we might want to migrate and set it to 0. or set it to a sane default.
|
Looks like this PR breaks a Prover rule |
Description
IDelegationManager.OperatorDetails.earningsReceiveris not being used as part of payments so to avoid confusion with the upcoming release of Payments we are deprecating this address slot in theOperatorDetailsstruct.Since a non-zero address of
earningsReceiveris being used to check whether an address is an operator or not, theisOperator(operator)function is now changed to simply checkdelegatedTo[operator] == operator. That is a operator is an operator iff they are delegated to themselves.Changes
earningsReceiverto__deprecated_earningsReceiverisOperatorchecks an address is self delegated now_delegate()no longer checks thestakeris not delegated and thatoperatoris an operator. It assumes these checks are made prior to the internal call. This was needed to fix operator registration because of howisOperatorwas changed.Delegation.t.sol