Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Window with List of Devices #12

Closed
BrunoFischerGermany opened this issue Jul 10, 2024 · 6 comments
Closed

Add new Window with List of Devices #12

BrunoFischerGermany opened this issue Jul 10, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@BrunoFischerGermany
Copy link
Contributor

Dear @Lazza,

What do you think about a dialog box that shows the Mac's devices?

I have experimented with diskutil list etc.

here is a screenshot, what do you think?
image

Greets
Bruno

@Lazza
Copy link
Owner

Lazza commented Jul 16, 2024

This seems interesting, thanks. I hope I will be able to have a look soon... In the meantime I will think how to go about placing a button for this (I don't like the large button very much).

@BrunoFischerGermany
Copy link
Contributor Author

hello @Lazza,
thank you for your relpy. I didn't know where to put the button either, so I just put it under the source field. Since I'm not that good with WXPython, I hope you can find a better version.
If you accept the PR, I would ask you to publish a new release.

Best regards from Berlin.

@Lazza
Copy link
Owner

Lazza commented Jul 18, 2024

If you accept the PR, I would ask you to publish a new release.

Yes, I am planning a new release soon in any case, because there are also important fixes for old macOS versions (e.g. High Sierra) and the new Sysdiagnose module.

@BrunoFischerGermany
Copy link
Contributor Author

BrunoFischerGermany commented Jul 18, 2024

Yes, I am planning a new release soon in any case

Perfect ✅

@Lazza
Copy link
Owner

Lazza commented Aug 21, 2024

Fixed by #15.

@Lazza Lazza closed this as completed Aug 21, 2024
@Lazza Lazza added the enhancement New feature or request label Aug 21, 2024
@Lazza
Copy link
Owner

Lazza commented Aug 21, 2024

In the end I think the button looks better now by adding a longer label. I still think there has to be a better way to display it, but it's not a priority for now.

Release 1.1.0 is ready: https://github.com/Lazza/Fuji/releases/tag/1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants