Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch problems with Internet Explorer 11 (seen on Windows 8.1 RTM) and Leaflet #2037

Closed
Ernie23 opened this issue Sep 20, 2013 · 13 comments · Fixed by #2066
Closed

Touch problems with Internet Explorer 11 (seen on Windows 8.1 RTM) and Leaflet #2037

Ernie23 opened this issue Sep 20, 2013 · 13 comments · Fixed by #2066
Assignees
Labels
blocker Critical issue or PR that must be resolved before the next release
Milestone

Comments

@Ernie23
Copy link
Contributor

Ernie23 commented Sep 20, 2013

Have some touch problems when i open a website with Leaflet in the new Internet Explorer 11. Zoom, Pinch to zoom and other touch gestures does not work. After that the Leaflet control is unresponsive. I got this issue on several tablets / touch devices with Windows 8.1 (RTM) and IE11. It seems that the IE11 uses pointerevents instead of ms-pointerevents.

I found this on http://msdn.microsoft.com/en-us/library/ie/hh772103(v=vs.85).aspx

@mourner
Copy link
Member

mourner commented Sep 20, 2013

@danzel Dave, you're the one to save the day here :)

@ghost ghost assigned danzel Sep 20, 2013
@danzel
Copy link
Member

danzel commented Sep 20, 2013

oh wow.... thats um a great change microsoft....
Will try do a fix next week, going to need some remote testing as I don't have 8.1 access.

@mourner
Copy link
Member

mourner commented Sep 20, 2013

We could also try doing a blind fix in a separate branch (if it's really a prefix issue) and ask@Ernie23 to test :)

@DanielX2
Copy link

Hi, i fixed the issue with pointer based devices in leaflet.

It's testet on our Surface Pro with win 8.0 and 8.1, our IPad and all other common desktop browsers.

Where can I upload or post these changes?

@mourner
Copy link
Member

mourner commented Sep 20, 2013

@DanielX2 that's awesome! You just need to send a pull request, take a look at this guide: https://help.github.com/articles/fork-a-repo

@DanielX2
Copy link

@mourner I have made an pull request with my changes. I hope everything is allrigth with it.

@mourner
Copy link
Member

mourner commented Sep 28, 2013

@danzel hey Dave, did you look at this too?

@danzel
Copy link
Member

danzel commented Sep 30, 2013

#2039 is the related PR.
We need to do something like that but less of a mess. Will take a look later this week.

@mourner
Copy link
Member

mourner commented Oct 3, 2013

Lets aim for a stable release with a fix before IE11 massively goes live. :)

@danzel
Copy link
Member

danzel commented Oct 3, 2013

gonna take a crack at it today

@danzel
Copy link
Member

danzel commented Oct 4, 2013

Looks like chrome will eventually use pointer events rather than touch as it does now
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22890 and linked discussion

@mourner
Copy link
Member

mourner commented Oct 10, 2013

@Ernie23 @DanielX2 can you confirm the pull request above fixes it on mobile tablets with IE11?

@Ernie23
Copy link
Contributor Author

Ernie23 commented Oct 23, 2013

hi
i tested your changes. it works perfectly but after pinch to zoom, the infobubble will be shown everytime.
i command out line 41 in DomEvent.Pointer.js....

made appropriate pull request for this... hope everything is fine, cause i am using github for the first time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Critical issue or PR that must be resolved before the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants