Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent pointerdown if target is a form control #4371

Merged
merged 2 commits into from
Apr 15, 2016

Conversation

perliedman
Copy link
Member

This is WIP to attempt fixing #2699.

The current approach is to white-list some tag types and not call preventDefault if they're the target, more or less what @fnicollet suggests. This seems to fix the problem, but I can't say it's elegant.

The other alternative I've considered involves actually calling stopPropagation on every form element (like suggested by @danzel: #2699 (comment)) which is messy and something people are likely to not understand that they have to do.

Any better solution? @danzel, do you have any suggestions?

@danzel
Copy link
Member

danzel commented Apr 2, 2016

If the only time we need this is for pointer events, then this is probably an ok place to do it.
Definitely want a note explaining why though, cause it's a weird thing to do!

Could we do a prosthetic hand test?

I like that this is something that we handle vs forcing users to do it.

@perliedman
Copy link
Member Author

I added a comment.

Not entirely sure if prosthetic hand can do this, I tried just very quickly to hack up something that touches a control, but couldn't make it actually open the control. @IvanSanchez what do you think, is this something we could prosthetic for?

@perliedman perliedman changed the title Don't prevent pointerdown if target is a form control. [DON'T MERGE] Don't prevent pointerdown if target is a form control Apr 15, 2016
@perliedman
Copy link
Member Author

So, I removed the "DON'T MERGE" warning from the title. Given current feedback it seems like an ok approach, and fixes a real issue for IE11 users.

A test would be nice, but I haven't been able to get prosthetic hand to click on on a select control so far; don't know if I can expect it to do that.

@yohanboniface yohanboniface merged commit ce9b9f5 into master Apr 15, 2016
@yohanboniface yohanboniface deleted the handle-touch-controls-ie11 branch April 15, 2016 14:10
yohanboniface added a commit that referenced this pull request Apr 15, 2016
perliedman pushed a commit that referenced this pull request Apr 18, 2016
* First version of rc1 changelog (cf #4379)

* fixed changelog

typos, closed PR removed, contributor added

* Prettify and fix minor typos in rc1 changelog

* Mention #4396 in the CHANGELOG

* Add mention of #4371

* Add docs updates by nathancahill

* Add info on #4387

* Update date for 1.0-rc1

* Remove double PR reference for #4418
@Malvoz Malvoz added the ie Internet Explorer label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ie Internet Explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants