Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not properly handling an error when attempting to retrieve a player not in the db #214

Closed
heyheyjp opened this issue Jul 1, 2016 · 1 comment
Labels

Comments

@heyheyjp
Copy link
Collaborator

heyheyjp commented Jul 1, 2016

2016-07-01T18:05:41.807192+00:00 app[web.1]: [LG SSO] found user, updating Rocket.Chat user info
2016-07-01T18:05:41.823217+00:00 app[web.1]: [LG SSO] setting avatar from gravatar
2016-07-01T18:05:42.140741+00:00 app[web.1]: [LG SSO] ERROR getting player info Error: Cannot perform merge on a non-object non-sequence `null` in:
2016-07-01T18:05:42.140752+00:00 app[web.1]: r.table("players").get("1bf04083-260f-4fba-9972-cb09474aa579").merge({
2016-07-01T18:05:42.140753+00:00 app[web.1]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2016-07-01T18:05:42.140754+00:00 app[web.1]:     chapter: r.table("chapters").get(r.row("chapterId"))
2016-07-01T18:05:42.140755+00:00 app[web.1]: }).without("chapterId")
2016-07-01T18:05:42.140756+00:00 app[web.1]:
2016-07-01T18:05:42.140757+00:00 app[web.1]:     at lib/graphQLFetcher.js:49:17
2016-07-01T18:05:42.140758+00:00 app[web.1]:     at /app/.meteor/heroku_build/app/programs/server/npm/promise/node_modules/meteor-promise/fiber_pool.js:33:40
2016-07-01T18:05:42.145153+00:00 app[web.1]: [LG SSO] error signing-in using SSO on idm service Error: Cannot perform merge on a non-object non-sequence `null` in:
2016-07-01T18:05:42.145167+00:00 app[web.1]:     at Object.Future.wait (/app/.meteor/heroku_build/app/programs/server/node_modules/fibers/future.js:398:15)
2016-07-01T18:05:42.145168+00:00 app[web.1]:     at fetchPlayer (server/sso.js:35:14)
2016-07-01T18:05:42.145169+00:00 app[web.1]:     at createOrUpdateUserFromJWT (server/sso.js:128:22)
2016-07-01T18:05:42.145170+00:00 app[web.1]:     at [object Object].Meteor.publish.Meteor.users.find._id (server/sso.js:150:20)
2016-07-01T18:05:42.145171+00:00 app[web.1]:     at accounts_server.js:462:32
2016-07-01T18:05:42.145171+00:00 app[web.1]:     at tryLoginMethod (accounts_server.js:239:14)
2016-07-01T18:05:42.145172+00:00 app[web.1]:     at AccountsServer.Ap._runLoginHandlers (accounts_server.js:459:18)
2016-07-01T18:05:42.145173+00:00 app[web.1]:     at [object Object].methods.login (accounts_server.js:522:27)
2016-07-01T18:05:42.145173+00:00 app[web.1]:     at maybeAuditArgumentChecks (livedata_server.js:1698:12)
2016-07-01T18:05:42.145174+00:00 app[web.1]:     at livedata_server.js:708:19
2016-07-01T18:05:42.145175+00:00 app[web.1]:     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
2016-07-01T18:05:42.145175+00:00 app[web.1]:     at livedata_server.js:706:40
2016-07-01T18:05:42.145176+00:00 app[web.1]:     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
2016-07-01T18:05:42.145177+00:00 app[web.1]:     at livedata_server.js:704:46
2016-07-01T18:05:42.145178+00:00 app[web.1]:     at tryCallTwo (/app/.meteor/heroku_build/app/programs/server/npm/promise/node_modules/meteor-promise/node_modules/promise/lib/core.js:45:5)
2016-07-01T18:05:42.145179+00:00 app[web.1]:     at doResolve (/app/.meteor/heroku_build/app/programs/server/npm/promise/node_modules/meteor-promise/node_modules/promise/lib/core.js:171:13)
2016-07-01T18:05:42.145180+00:00 app[web.1]:     at new Promise (/app/.meteor/heroku_build/app/programs/server/npm/promise/node_modules/meteor-promise/node_modules/promise/lib/core.js:65:3)
2016-07-01T18:05:42.145180+00:00 app[web.1]:     at [object Object]._.extend.protocol_handlers.method (livedata_server.js:678:23)
2016-07-01T18:05:42.145181+00:00 app[web.1]:     at livedata_server.js:548:43
2016-07-01T18:05:42.145182+00:00 app[web.1]:     - - - - -
2016-07-01T18:05:42.145183+00:00 app[web.1]: r.table("players").get("1bf04083-260f-4fba-9972-cb09474aa579").merge({
2016-07-01T18:05:42.145183+00:00 app[web.1]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2016-07-01T18:05:42.145184+00:00 app[web.1]:     chapter: r.table("chapters").get(r.row("chapterId"))
2016-07-01T18:05:42.145185+00:00 app[web.1]: }).without("chapterId")
2016-07-01T18:05:42.145185+00:00 app[web.1]:
2016-07-01T18:05:42.145186+00:00 app[web.1]:     at lib/graphQLFetcher.js:49:17
2016-07-01T18:05:42.145186+00:00 app[web.1]:     at /app/.meteor/heroku_build/app/programs/server/npm/promise/node_modules/meteor-promise/fiber_pool.js:33:40
2016-07-01T18:05:42.518531+00:00 app[web.1]: Set needdra's avatar from the url: https://secure.gravatar.com/avatar/dfc1746bf932a7a5da2f81b687ea7b86?default=https%253A%252F%252Flg-initials-avatar.herokuapp.com%252Fneeddra&size=200
@jeffreywescott
Copy link
Contributor

This should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants