Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Accounting and bucket crawler failure recovery #687

Merged
merged 14 commits into from
Jan 22, 2018
Merged

Accounting and bucket crawler failure recovery #687

merged 14 commits into from
Jan 22, 2018

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented Jan 17, 2018

Mitigates #686

@exarkun exarkun requested review from meejah and crwood January 18, 2018 14:12
meejah
meejah approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! 👍

Could maybe make "60 * 60" a module-level constant for "recent"

@exarkun exarkun merged commit 8db2bb6 into master Jan 22, 2018
@exarkun exarkun deleted the 686.crawl-health branch January 22, 2018 13:47
@exarkun exarkun mentioned this pull request Jan 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meejah meejah meejah approved these changes

@crwood crwood Awaiting requested review from crwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exarkun @meejah