Remove redundant NaN clean of melbank

[bigredfrog]

The call to melbank_no_nan in the Audio self.melbank() is the only one needed.

melbank_thirds does not need an additional call, it will already be cleaned for NaNs

Older code would of only cleaned melbank, not the thirds. But the newer code is good as it cleans directly in melbank, and thirds is derived

Tested by NaN injection and single stepping in debug

Summary by CodeRabbit

• Refactor
  • Improved the processing efficiency of audio effects by refining the method used for handling melbank data.

[coderabbitai]

Walkthrough

The modification involves the removal of a function call to melbank_no_nan within the melbank_thirds method. This change directly impacts how melbank data is processed, specifically before it undergoes splitting according to predefined criteria. The alteration suggests a refinement in handling melbank data, potentially enhancing the efficiency or accuracy of the audio effect processing in the application.

Changes

File(s)	Change Summary
ledfx/effects/audio.py	Removed the call to melbank_no_nan in the melbank_thirds method, affecting melbank processing before splits.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a664f6a and e9e1135.

Files selected for processing (1)

• ledfx/effects/audio.py (1 hunks)

Additional comments: 1

ledfx/effects/audio.py (1)

• 948-951: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The PR's objective to remove redundant NaN cleaning from the melbank_thirds method aligns with the rationale provided. However, the specific change is not directly annotated in the provided code. It's important to ensure that the removal of the melbank_no_nan call from melbank_thirds does not negatively impact the data integrity downstream, especially considering that melbank data is already cleaned of NaNs upstream.