Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

No window size & position save after app restart #1428

Closed
andreasmaks opened this issue Aug 16, 2018 · 6 comments
Closed

No window size & position save after app restart #1428

andreasmaks opened this issue Aug 16, 2018 · 6 comments
Labels
good first issue this is an easy to fix task. typically something the community can take. regression subtype of bug. this used to work, this no longer

Comments

@andreasmaks
Copy link

Ledger Live Version and Operating System

  • tested on Ledger Live v1.1.6
  • Platform and version: Mac 10.13.6

Expected behavior

  • resize and repositioning window
  • reopen App
  • app opens in new size and position

Actual behavior

  • resize and repositioning window
  • reopen App
  • app opens in default size and position
@gre gre added regression subtype of bug. this used to work, this no longer needs investigation for bug: we need to investigate what's going on. for feature: need to think about way to implement labels Aug 17, 2018
@andreasmaks
Copy link
Author

Any updates on this?

@gre gre added good first issue this is an easy to fix task. typically something the community can take. and removed needs investigation for bug: we need to investigate what's going on. for feature: need to think about way to implement labels Sep 30, 2018
@gre
Copy link
Contributor

gre commented Sep 30, 2018 •
edited

the issue is that

https://github.com/LedgerHQ/ledger-live-desktop/blob/develop/src/main/app.js#L72

and

https://github.com/LedgerHQ/ledger-live-desktop/blob/develop/src/main/app.js#L80

seems to be saved in a different db location

https://github.com/LedgerHQ/ledger-live-desktop/blob/develop/src/main/app.js#L98-L99

it's an easy fix if anyone want to tackle it down.

@juan-cortes juan-cortes mentioned this issue Sep 30, 2018
Merged
@juan-cortes
Copy link
Contributor

Added a pr for this since it was already obvious how to fix it :trollface:

@meriadec meriadec mentioned this issue Oct 17, 2018
Merged
@juan-cortes
Copy link
Contributor

This is done :)

@gre gre closed this as completed Oct 18, 2018
@imclint21
Copy link

imclint21 commented Aug 22, 2019 •
edited

Not really done,

When you maximize app, you close and you reopen the maximized state is not saved.

Example:

image

@juan-cortes
Copy link
Contributor

It's working on mac, damn..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue this is an easy to fix task. typically something the community can take. regression subtype of bug. this used to work, this no longer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gre @andreasmaks @juan-cortes @imclint21