Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #6189 support/bump-stellar-sdk" #6338

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

hedi-edelbloute
Copy link
Member

This reverts commit 6a0c185, reversing changes made to 826a498.

📝 Description

Causes an issue specific to ledger live mobile

image

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hedi-edelbloute hedi-edelbloute requested a review from a team as a code owner February 29, 2024 15:43
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 3:46pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Feb 29, 2024 3:46pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 29, 2024 3:46pm
native-ui-storybook ⬜️ Ignored (Inspect) Feb 29, 2024 3:46pm
react-ui-storybook ⬜️ Ignored (Inspect) Feb 29, 2024 3:46pm

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Feb 29, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/preset-env@7.17.10 environment Transitive: filesystem, unsafe +100 20.2 MB nicolo-ribaudo
npm/@babel/preset-react@7.16.7 Transitive: environment, filesystem, unsafe +28 9.74 MB nicolo-ribaudo
npm/@babel/preset-react@7.22.15 Transitive: environment, filesystem, unsafe +25 9.72 MB nicolo-ribaudo
npm/@babel/preset-react@7.23.3 Transitive: environment, filesystem, unsafe +27 9.73 MB nicolo-ribaudo
npm/@babel/runtime@7.17.9 None 0 173 kB nicolo-ribaudo
npm/@babel/runtime@7.22.10 None 0 282 kB nicolo-ribaudo
npm/@braze/react-native-sdk@8.0.0 None 0 252 kB appboy
npm/@braze/web-sdk@4.6.3 None 0 415 kB appboy
npm/@cardano-foundation/ledgerjs-hw-app-cardano@6.0.1 None 0 633 kB jan.mazak
npm/@celo/connect@3.0.1 None +2 811 kB alecps
npm/@celo/contractkit@3.0.1 filesystem, network +3 3.66 MB alecps
npm/@celo/utils@3.0.1 None +1 700 kB alecps
npm/@celo/wallet-base@3.0.1 None +3 853 kB alecps
npm/@celo/wallet-ledger@3.0.1 None +5 930 kB alecps
npm/@changesets/changelog-github@0.5.0 Transitive: environment, network +2 98 kB changesets-release-bot
npm/@changesets/cli@2.26.0 environment, filesystem, shell +16 1.12 MB changesets-release-bot
npm/@commitlint/cli@17.4.2 Transitive: environment, filesystem +15 278 kB escapedcat
npm/@commitlint/config-conventional@17.6.5 None 0 9.6 kB escapedcat
npm/@commitlint/prompt-cli@17.4.2 Transitive: environment +7 154 kB escapedcat
npm/@cosmjs/amino@0.31.1 None +4 302 kB webmaster128
npm/@cosmjs/crypto@0.31.0 None +3 213 kB webmaster128
npm/@cosmjs/stargate@0.26.6 Transitive: network +11 2.98 MB webmaster128
npm/@craftamap/esbuild-plugin-html@0.6.1 filesystem 0 26.7 kB craftamap
npm/@crypto-org-chain/chain-jslib@1.1.2 Transitive: network +22 10.5 MB calvinaco
npm/@dfinity/agent@0.21.4 network +2 2.06 MB krpeacock
npm/@dfinity/candid@0.21.4 None +1 787 kB krpeacock
npm/@dfinity/principal@0.15.6 None 0 140 kB krpeacock
npm/@electron/notarize@2.3.0 filesystem, shell 0 64.5 kB electron-cfa
npm/@elrondnetwork/erdjs-network-providers@1.2.0 None 0 179 kB andreibancioiu
npm/@elrondnetwork/erdjs@11.0.0 None +1 629 kB lucian.mincu
npm/@emotion/core@11.0.0 environment 0 17.1 kB emotion-release-bot
npm/@emotion/native@11.11.0 environment +1 75.3 kB emotion-release-bot
npm/@ethersproject/abi@5.6.1 None +1 530 kB ricmoo

🚮 Removed packages: npm/react-native@1000.0.0, npm/styled-components@6.1.8

View full report↗︎

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Feb 29, 2024

Desktop Bundle Checks

Comparing 80f4f3a against ca86b3f.

🚀 renderer bundle size decreased (36.6mb -> 36.2mb). Thanks ❤️
⚠️ long library is now duplicated in renderer (regression)

Mobile Bundle Checks

Comparing 80f4f3a against ca86b3f.

🚀 main.ios.jsbundle bundle size decreased (58.6mb -> 58.3mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (58.7mb -> 58.3mb). Thanks ❤️

@hedi-edelbloute hedi-edelbloute merged commit 4b45893 into develop Feb 29, 2024
56 of 59 checks passed
@hedi-edelbloute hedi-edelbloute deleted the support/revert-bump-stellar-sdk branch February 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant