-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump stellar-sdk from 10.4.1 to 11.2.2. #6189
chore(deps): Bump stellar-sdk from 10.4.1 to 11.2.2. #6189
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
3 Ignored Deployments
|
@overcat is attempting to deploy a commit to the LedgerHQ Team on Vercel. A member of the Team first needs to authorize it. |
3a4c80f
to
fa4886c
Compare
New and removed dependencies detected. Learn more about Socket for GitHub βοΈ
|
π¨ Potential security issues detected. Learn more about Socket for GitHub βοΈ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending CI and QA
β¦k-release Revert "Merge pull request #6189 support/bump-stellar-sdk"
Revert "Merge pull request #6189 support/bump-stellar-sdk"
β¦/bump-stellar-sdk"" This reverts commit 80f4f3a.
π Description
This PR is used to upgrade the stellar-sdk we use. Since the latest version contains breaking changes, we need to create this PR to manually upgrade it. The upgrade guide can be found here: https://gist.github.com/Shaptic/5ce4f16d9cce7118f391fbde398c2f30
β Context
https://ledgerhq.atlassian.net/browse/LIVE-11332
β Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.π§ Checklist for the PR Reviewers