Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump stellar-sdk from 10.4.1 to 11.2.2. #6189

Merged

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Feb 14, 2024

πŸ“ Description

This PR is used to upgrade the stellar-sdk we use. Since the latest version contains breaking changes, we need to create this PR to manually upgrade it. The upgrade guide can be found here: https://gist.github.com/Shaptic/5ce4f16d9cce7118f391fbde398c2f30

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-11332

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@overcat overcat requested review from a team as code owners February 14, 2024 01:13
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 14, 2024 1:22am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 1:22am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 1:22am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 1:22am

Copy link

vercel bot commented Feb 14, 2024

@overcat is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs fork Pull request base branch comes from a fork. labels Feb 14, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub β†—οΈŽ

Package New capabilities Transitives Size Publisher
npm/@stellar/stellar-sdk@11.2.2 Transitive: environment, filesystem, network +20 39.6 MB

View full reportβ†—οΈŽ

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub β†—οΈŽ

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Native code npm/sodium-native@4.0.8
  • orphan: npm/sodium-native@4.0.8

View full reportβ†—οΈŽ

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/sodium-native@4.0.8

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI and QA

@hedi-edelbloute hedi-edelbloute merged commit 6a0c185 into LedgerHQ:develop Feb 23, 2024
45 of 46 checks passed
hedi-edelbloute added a commit that referenced this pull request Feb 29, 2024
hedi-edelbloute added a commit that referenced this pull request Feb 29, 2024
hedi-edelbloute added a commit that referenced this pull request Feb 29, 2024
…k-release

Revert "Merge pull request #6189 support/bump-stellar-sdk"
hedi-edelbloute added a commit that referenced this pull request Feb 29, 2024
Revert "Merge pull request #6189 support/bump-stellar-sdk"
overcat added a commit to lightsail-network/ledger-live that referenced this pull request Mar 1, 2024
KVNLS pushed a commit that referenced this pull request Mar 21, 2024
KVNLS pushed a commit that referenced this pull request Mar 27, 2024
KVNLS pushed a commit that referenced this pull request Mar 27, 2024
KVNLS pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants