Merge pull request #6206 from StricaHQ/bugfix/cardano-stake-btn

fix canStake method

.changeset/tough-hairs-retire.md

@@ -0,0 +1,6 @@
+---
+"ledger-live-desktop": patch
+"@ledgerhq/live-common": patch
+---
+
+Cardano stake button fix

apps/ledger-live-desktop/src/renderer/families/cardano/AccountHeaderManageActions.ts

@@ -1,6 +1,6 @@
 import { getMainAccount } from "@ledgerhq/live-common/account/index";
 import { CardanoAccount } from "@ledgerhq/live-common/families/cardano/types";
-import { canStake } from "@ledgerhq/live-common/families/cardano/logic";
+import { canStake, isAlreadyStaking } from "@ledgerhq/live-common/families/cardano/logic";
 import { Account, AccountLike } from "@ledgerhq/types-live";
 import invariant from "invariant";
 import { useCallback } from "react";
@@ -21,7 +21,8 @@ const AccountHeaderActions = ({ account, parentAccount }: Props) => {
   const { cardanoResources } = mainAccount as CardanoAccount;
   invariant(cardanoResources, "cardano account expected");
 
-  const disableStakeButton = !canStake(account as CardanoAccount);
+  const disableStakeButton =
+    !canStake(account as CardanoAccount) || isAlreadyStaking(account as CardanoAccount);
 
   const disabledLabel =
     cardanoResources.delegation && cardanoResources.delegation.poolId

libs/ledger-live-common/src/families/cardano/logic.ts

@@ -64,7 +64,15 @@ export function getBipPathFromString(path: string): BipPath {
  * @returns true if the account can stake, false otherwise
  */
 export function canStake(account: CardanoAccount): boolean {
-  return !!account?.cardanoResources?.delegation?.poolId && !account.balance.isZero();
+  return !!account.balance?.gt(0);
+}
+
+/**
+ *
+ * @returns true if account is staked, false otherwise
+ */
+export function isAlreadyStaking(account: CardanoAccount): boolean {
+  return !!account?.cardanoResources?.delegation?.poolId;
 }
 
 /**

libs/ledger-live-common/src/families/cardano/logic.unit.test.ts

@@ -1,51 +1,44 @@
 import BigNumber from "bignumber.js";
-import { canStake } from "./logic";
+import { canStake, isAlreadyStaking } from "./logic";
 import { CardanoAccount } from "./types";
 
 describe("canStake", () => {
-  it("should return false when acc delegation data is incomplete", () => {
+  it("should return false when acc not present", () => {
     const noResourcesAcc = {} as CardanoAccount;
     expect(canStake(noResourcesAcc)).toEqual(false);
-    const noDelegationAcc = {
-      cardanoResources: {},
-      balance: new BigNumber(1),
-    } as CardanoAccount;
-    expect(canStake(noDelegationAcc)).toEqual(false);
-    const noPoolIdAcc = {
-      balance: new BigNumber(1),
-      cardanoResources: {
-        delegation: {},
-      },
-    } as CardanoAccount;
-    expect(canStake(noPoolIdAcc)).toEqual(false);
   });
 
-  it("should return false when acc already has a delegation but no funds", () => {
-    const poolIdNoFundsAcc = {
+  it("should return false when acc has no funds", () => {
+    const accWithNoFunds = {
       balance: new BigNumber(0),
-      cardanoResources: {
-        delegation: {
-          poolId: "helloiamapoolid",
-        },
-      },
     } as CardanoAccount;
-    expect(canStake(poolIdNoFundsAcc)).toEqual(false);
+    expect(canStake(accWithNoFunds)).toEqual(false);
   });
 
-  it("should return false when acc has no funds", () => {
-    const noResourcesAcc = { balance: new BigNumber(0) } as CardanoAccount;
-    expect(canStake(noResourcesAcc)).toEqual(false);
+  it("should return true when acc has funds", () => {
+    const accWithFunds = {
+      balance: new BigNumber(1),
+    } as CardanoAccount;
+    expect(canStake(accWithFunds)).toEqual(true);
   });
+});
 
-  it("should return true when acc already has a delegation and funds", () => {
-    const poolIdAcc = {
-      balance: new BigNumber(1),
-      cardanoResources: {
-        delegation: {
-          poolId: "helloiamapoolid",
-        },
-      },
+describe("isAlreadyStaking", () => {
+  it("should return false when acc isn't delegating", () => {
+    const noResourcesAcc = {} as CardanoAccount;
+    expect(isAlreadyStaking(noResourcesAcc)).toEqual(false);
+    const noDelegationAcc = {
+      cardanoResources: {},
+    } as CardanoAccount;
+    expect(isAlreadyStaking(noDelegationAcc)).toEqual(false);
+    const noPoolIdAcc = { cardanoResources: { delegation: {} } } as CardanoAccount;
+    expect(isAlreadyStaking(noPoolIdAcc)).toEqual(false);
+  });
+
+  it("should return true when acc is delegating", () => {
+    const noResourcesAcc = {
+      cardanoResources: { delegation: { poolId: "itspoolid" } },
     } as CardanoAccount;
-    expect(canStake(poolIdAcc)).toEqual(true);
+    expect(isAlreadyStaking(noResourcesAcc)).toEqual(true);
   });
 });