Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #6189 support/bump-stellar-sdk" #6339

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

hedi-edelbloute
Copy link
Member

This reverts commit 6a0c185, reversing changes made to 826a498.

πŸ“ Description

Causes an issue specific to ledger live mobile
image

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hedi-edelbloute hedi-edelbloute requested a review from a team as a code owner February 29, 2024 15:53
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 29, 2024 3:58pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Feb 29, 2024 3:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 29, 2024 3:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Feb 29, 2024 3:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Feb 29, 2024 3:58pm

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Feb 29, 2024
@hedi-edelbloute hedi-edelbloute changed the title Revert "Merge pull request #6189 from overcat/support/bump-stellar-sdk" Revert "Merge pull request #6189 support/bump-stellar-sdk" Feb 29, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Feb 29, 2024

Desktop Bundle Checks

Comparing 8c79cbc against 2f4b645.

πŸš€ renderer bundle size decreased (36.6mb -> 36.2mb). Thanks ❀️
⚠️ long library is now duplicated in renderer (regression)

Mobile Bundle Checks

Comparing 8c79cbc against a470b8a.

πŸš€ main.ios.jsbundle bundle size decreased (58.6mb -> 58.3mb). Thanks ❀️
πŸš€ main.android.jsbundle bundle size decreased (58.7mb -> 58.3mb). Thanks ❀️

@hedi-edelbloute hedi-edelbloute merged commit ec9366e into release Feb 29, 2024
52 of 60 checks passed
@hedi-edelbloute hedi-edelbloute deleted the support/revert-bump-stellar-sdk-release branch February 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant