Improvement of backendbench assistant. #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borg323
reviewed
Jan 10, 2021
src/benchmark/backendbench.cc
Outdated
|
|
||
| if (nps > best_nps) { | ||
| if (best==0 || | ||
| ((i*1.0f/best*1.0f-1.0f)*threshold < nps/best_nps-1.0f)) { |
There was a problem hiding this comment.
You can rewrite this as (i-best)*threshold*best_nps < (nps-best_nps)*best.
Then you can initialize best to 1 to avoid the best==0 check and the nested if.
borg323
reviewed
Jan 10, 2021
src/benchmark/backendbench.cc
Outdated
| @@ -79,8 +75,7 @@ void BackendBenchmark::Run() { | |||
| options.Add<IntOption>(kMaxBatchSizeId, 1, 1024) = 256; | |||
| options.Add<StringOption>(kFenId) = ChessBoard::kStartposFen; | |||
| options.Add<BoolOption>(kClippyId) = false; | |||
| options.Add<FloatOption>(kClippyThresholdId, 0.0f, 1.0f) = 0.05f; | |||
| options.Add<FloatOption>(kClippyToleranceId, 0.0f, 1.0f) = 0.03f; | |||
| options.Add<FloatOption>(kClippyThresholdId, 0.0f, 1.0f) = 0.1f; | |||
There was a problem hiding this comment.
You suggestion to change the default to 0.2 seems reasonable,
There was a problem hiding this comment.
0.2 would be my best bet for max. playing strength, favoring lower batch sizes. Can be changed later, if someone conducts more tests.
borg323
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic is to replace batchsize with highest nps, if new nps is 1+threshold times higher than previous best.
However, it is known that generally higher batchsize numbers perform worse in gameplay, e.g. a 4x higher batchsize with 1.05x higher nps shouldn't be accepted while a 1.10x higher batchsize with 1.04x higher nps is most probably better.
Now the acceptance rule is based on a linear function requiring +10% nps (compared to previous best) for each +100% of batchsize (to previous best).
Example:
Edit: Based on some short test matches I suspect that the default threshold can be increased from 0.1 to 0.2 (+15% nps with 2x batchsize was weaker in a test):