Use edge to edge #1351
Merged
Use edge to edge #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dessalines I think to fix this, we might have to do some drastic refactors I think it caused by the nested bottomNavHost with the drawer, it might have to made part of the root navhost and use state to enable the drawer/bottomnav visiblity It is probably solveable in other way but I haven't found it yet. I think its applying some padding twice |
|
Seems unavoidable, since that uiController's deprecated. |
|
Found the real culprit val bottomPadding =
if (selectedTab == NavTab.Search && WindowInsets.isImeVisible) {
0.dp
} else {
padding.calculateBottomPadding()
}This was being applied to the navhost, which has weird side effects |
MV-GH
commented
Mar 7, 2024
| @@ -55,7 +55,7 @@ fun JerboaTheme( | |||
| ), | |||
| ) | |||
| } else { | |||
| pink() | |||
| blue() | |||
There was a problem hiding this comment.
I don't like the pink theme as default 👯
dessalines
reviewed
Mar 8, 2024
| @@ -261,6 +246,7 @@ fun ViewerHeader( | |||
| ) | |||
| } | |||
| }, | |||
| // pzv9dPd8iL | |||
There was a problem hiding this comment.
Typo here, feel free to merge after you fixed tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour should be the same as before.
Also fixes #1184
Caused by that padding