-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use edge to edge #1351
Use edge to edge #1351
Conversation
@dessalines I think to fix this, we might have to do some drastic refactors I think it caused by the nested bottomNavHost with the drawer, it might have to made part of the root navhost and use state to enable the drawer/bottomnav visiblity It is probably solveable in other way but I haven't found it yet. I think its applying some padding twice |
Seems unavoidable, since that uiController's deprecated. |
Found the real culprit val bottomPadding =
if (selectedTab == NavTab.Search && WindowInsets.isImeVisible) {
0.dp
} else {
padding.calculateBottomPadding()
} This was being applied to the navhost, which has weird side effects |
@@ -55,7 +55,7 @@ fun JerboaTheme( | |||
), | |||
) | |||
} else { | |||
pink() | |||
blue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the pink theme as default 👯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha alright.
@@ -261,6 +246,7 @@ fun ViewerHeader( | |||
) | |||
} | |||
}, | |||
// pzv9dPd8iL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here, feel free to merge after you fixed tho.
Behaviour should be the same as before.
Also fixes #1184
Caused by that padding