-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Themes (Dark + Light) #750
Merged
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a770a11
Grey (Dark Theme)
bynatejones eadd8a3
Grey (Light Theme) + Dark changes
bynatejones 0a2a0f0
Purple Theme (Dark + Light)
bynatejones ebfa716
Merge branch 'main' into more-themes
bynatejones 7a0aa60
Woodland Theme (Dark + Light)
bynatejones 615feeb
Beach Theme (Dark + Light)
bynatejones 7440286
Alphabetized list of theme colors
bynatejones 84a3bb9
Crimson Theme (Dark + Light) and Adjustments on Beach Theme Dark
bynatejones d605cb3
Merge branch 'main' into more-themes
bynatejones e1da129
Merge branch 'main' into more-themes
dessalines 072f9f1
Modified ThemeColor to use i18n strings
bynatejones b15807a
Merge branch 'more-themes' of https://github.com/bynatejones/jerboa i…
bynatejones 31d7cba
Merge branch 'main' into more-themes
bynatejones 26c9263
Merge branch 'main' into more-themes
bynatejones 3da0479
Fixed lint error
bynatejones 240a1cb
Merge branch 'more-themes' of https://github.com/bynatejones/jerboa i…
bynatejones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a merge from main, and you'll see that this enum has i18n strings now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add i18n strings to this, just liken
ThemeMode
has above it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've modified them to use i18n strings and added the English translations in the strings.xml file