Reworked PickImage() composable #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sockenklaus
added a commit
to sockenklaus/jerboa
that referenced
this pull request
Jun 24, 2023
sockenklaus
added a commit
to sockenklaus/jerboa
that referenced
this pull request
Jun 25, 2023
twizmwazin
pushed a commit
that referenced
this pull request
Jun 25, 2023
* Did some refactoring on PostEdit and CreatePost activities, consolidating composables to reduce unnecessary redundancies. * removed unnecessary annotations, working on changed PickImage behaviour. WIP!!! * working on changed PickImage behaviour. WIP!!! * Fixed behaviour of PickImage(), it now displays the old image when editing a post. * PickImage now always loads the preview image from web, added uploadIndicator * Rerolled all changes regarding PickImage and put them in their own PR #877 * Removed some composables in PostComposables that appear only once and add unnecessary clutter. Added comments instead to structure the post body composable. * Reverted a change to isImage() that belongs to #877
# Conflicts: # app/src/main/java/com/jerboa/ui/components/post/create/CreatePost.kt # app/src/main/java/com/jerboa/ui/components/post/create/CreatePostActivity.kt # app/src/main/java/com/jerboa/ui/components/post/edit/PostEdit.kt # app/src/main/java/com/jerboa/ui/components/post/edit/PostEditActivity.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked this composable and made it (in my opinion) more elegant and show a more consistent behaviour: