-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make new comment indicator easier to distinguish #1812
base: main
Are you sure you want to change the base?
Conversation
<span className="badge text-bg-info"> | ||
({this.unreadCount} {I18NextService.i18n.t("new")}) | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall before we used the dull color, we colored the font instead of giving it a background. Maybe try that instead while keeping the italic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which theme color is that? I was thinking of using the info color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the UI used to use text-warning:
<span className="small text-warning">
({this.unreadCount} {i18n.t("new")})
</span>
This one I'm not a fan of. We had it as a badge color, but it just looks so much better as the same muted color as the comment count. It just needs emphasized in some way (either via italics like it was), or some other font emphasis. |
@dessalines Thanks for weighing in. Two different options: |
I don't feel strongly about this either. Would be fine with closing this. |
Description
The "(2 new)" comments indicator is too hard to miss now that it's just gray. This changes that.
Screenshots
Before
After