Fix CSP in dev mode #1918
Merged
Fix CSP in dev mode #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunaurus
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
SleeplessOne1917
approved these changes
Jul 12, 2023
dessalines
approved these changes
Jul 12, 2023
andrewstuart
added a commit
to andrewstuart/lemmy-ui
that referenced
this pull request
Jul 13, 2023
Handle errors from sharp Revert "Handle errors from sharp" This reverts commit 70f6268. Handle any sharp errors gracefully Add Toast Messages for Bad Logins (LemmyNet#1874) * Added toast prompts * Using generic message instead. --------- Co-authored-by: Jacob Rosenzweig <rosenjcb@Jacobs-MacBook-Pro.local> Co-authored-by: SleeplessOne1917 <abias1122@gmail.com> Fix CSP in dev mode (LemmyNet#1918) Remove invalid default option from language list (LemmyNet#1919) Set person_id to myId in handleLeaveModTeam (LemmyNet#1929)
dessalines
pushed a commit
that referenced
this pull request
Jul 21, 2023
andrewstuart
added a commit
to andrewstuart/lemmy-ui
that referenced
this pull request
Jul 24, 2023
Handle errors from sharp Revert "Handle errors from sharp" This reverts commit 70f6268. Handle any sharp errors gracefully Add Toast Messages for Bad Logins (LemmyNet#1874) * Added toast prompts * Using generic message instead. --------- Co-authored-by: Jacob Rosenzweig <rosenjcb@Jacobs-MacBook-Pro.local> Co-authored-by: SleeplessOne1917 <abias1122@gmail.com> Fix CSP in dev mode (LemmyNet#1918) Remove invalid default option from language list (LemmyNet#1919) Set person_id to myId in handleLeaveModTeam (LemmyNet#1929)
andrewstuart
added a commit
to andrewstuart/lemmy-ui
that referenced
this pull request
Jul 27, 2023
Handle errors from sharp Revert "Handle errors from sharp" This reverts commit 70f6268. Handle any sharp errors gracefully Add Toast Messages for Bad Logins (LemmyNet#1874) * Added toast prompts * Using generic message instead. --------- Co-authored-by: Jacob Rosenzweig <rosenjcb@Jacobs-MacBook-Pro.local> Co-authored-by: SleeplessOne1917 <abias1122@gmail.com> Fix CSP in dev mode (LemmyNet#1918) Remove invalid default option from language list (LemmyNet#1919) Set person_id to myId in handleLeaveModTeam (LemmyNet#1929)
andrewstuart
pushed a commit
to andrewstuart/lemmy-ui
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought I had CSP properly disabled in dev mode in #1907, but turns out I was wrong (I think I had multiple solutions for this active parallel locally and I committed the wrong one)
This PR just disables CSP when
NODE_ENV=development(which it is with build:dev)Sorry if this caused any inconvenience for anybody!