Add nonce-based CSP header #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunaurus
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
|
It's working with both |
dessalines
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Thanks!
I just deployed this to https://ds9.lemmy.ml , and everything seems to be working correctly.
SleeplessOne1917
approved these changes
Jul 10, 2023
dessalines
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Remove websocket config * Add nonce based CSP
Merged
andrewstuart
pushed a commit
to andrewstuart/lemmy-ui
that referenced
this pull request
Jul 27, 2023
* Remove websocket config * Add nonce based CSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #1900, let's keep data serialized as before, but use a nonce to protect against malicious scripts.
Also removes unused websocket config related script tag.