Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a post body field will not save an empty string #2287

Closed
GitOffMyBack opened this issue May 30, 2022 · 3 comments
Closed

Editing a post body field will not save an empty string #2287

GitOffMyBack opened this issue May 30, 2022 · 3 comments
Labels
area: api bug Something isn't working

Comments

@GitOffMyBack
Copy link

Issue Summary

Make a post and enter some text into the body field. Then click the edit post button. Clear out all the text in the body field leaving it blank. Then click save. The cleared out text will reappear.
@GitOffMyBack GitOffMyBack added the bug Something isn't working label May 30, 2022
@dessalines
Copy link
Member

I've found the culprit here, its the PostForm's not correctly using Option<Option<.. on the optional SQL columns.

@Nutomic Nutomic mentioned this issue Jun 21, 2022
Closed
dessalines added a commit that referenced this issue Jul 28, 2022
@dessalines
Fix a few form options for diesel. Fixes #2287
247ef36
@Nutomic Nutomic mentioned this issue Jul 29, 2022
Merged
dessalines added a commit that referenced this issue Jul 29, 2022
@dessalines
Fix a few form options for diesel. Fixes #2287
fde3e1f
@Nutomic
Copy link
Member

Nutomic commented Jul 29, 2022

Is this fixed, or just closed by accident?

@dessalines
Copy link
Member

dessalines commented Jul 29, 2022 •
edited
Loading

Its fixed by that commit.

@dessalines dessalines mentioned this issue Jun 5, 2024
Closed
5 tasks
dessalines added a commit that referenced this issue Jun 5, 2024
@dessalines
Allow empty string to clear URL-type DB fields.
013e392 
- To address difficulties with clearing URL-type fields like
  avatars, banners, site icons, this PR turns the URL type form
  fields into strings.
- This allows an empty string to be used as a "clear data", as
  in the case with the regular text form fields.
- Also includes various cleanups.
- Fixes #4777
- Context: #2287
@dessalines dessalines mentioned this issue Jun 5, 2024
Merged
dessalines added a commit that referenced this issue Jun 6, 2024
@dessalines @SleeplessOne1917
Allow empty string to clear URL-type DB fields. (#4780)
16a8286 
* Allow empty string to clear URL-type DB fields.

- To address difficulties with clearing URL-type fields like
  avatars, banners, site icons, this PR turns the URL type form
  fields into strings.
- This allows an empty string to be used as a "clear data", as
  in the case with the regular text form fields.
- Also includes various cleanups.
- Fixes #4777
- Context: #2287

* Fixing comment.

* Use Option<&str> and deref.

---------

Co-authored-by: SleeplessOne1917 <28871516+SleeplessOne1917@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dessalines @Nutomic @GitOffMyBack