Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require superuser permission to run database migrations #2863

Closed
Nutomic opened this issue May 15, 2023 · 2 comments · Fixed by #3002
Closed

Don't require superuser permission to run database migrations #2863

Nutomic opened this issue May 15, 2023 · 2 comments · Fixed by #3002
Labels
area: database enhancement New feature or request

Comments

@Nutomic
Copy link
Member

Nutomic commented May 15, 2023

Some admins reported problems installing Lemmy because the db migrations require superuser permissions. This is not available on some cloud hosting providers. So it would be nice if we could get rid of this requirement. Apparently the problem is caused by disable trigger all.

@Nutomic Nutomic added area: database enhancement New feature or request labels May 15, 2023
@CobaltCause
Copy link
Contributor

git blame says #2670.

I figured out how to work around this in #2784 (comment).

I didn't look at the feasibility of this but maybe some checks can be added around these queries to detect whether this is necessary and do so conditionally. I don't really know how bad the previous performance was, but maybe that PR could simply be reverted.

@dessalines
Copy link
Member

Not really sure of a good solution to this one. We shouldn't revert that PR, as its a DB migration. We might possibly be able to just remove that trigger disable. People have mostly upgraded past that point anyway.

CobaltCause added a commit to CobaltCause/lemmy that referenced this issue Jun 9, 2023
Fixes <LemmyNet#2863> and the problem
introduced by the previous commit.
CobaltCause added a commit to CobaltCause/lemmy that referenced this issue Jun 9, 2023
Fixes <LemmyNet#2863> and the problem
introduced by the previous commit.
CobaltCause added a commit to CobaltCause/lemmy that referenced this issue Jun 10, 2023
CobaltCause added a commit to CobaltCause/lemmy that referenced this issue Jun 12, 2023
Nutomic pushed a commit to CobaltCause/lemmy that referenced this issue Jun 12, 2023
CobaltCause added a commit to CobaltCause/lemmy that referenced this issue Jun 12, 2023
Nutomic pushed a commit to CobaltCause/lemmy that referenced this issue Jun 13, 2023
CobaltCause added a commit to CobaltCause/lemmy that referenced this issue Jun 13, 2023
Nutomic pushed a commit to CobaltCause/lemmy that referenced this issue Jun 14, 2023
Nutomic pushed a commit to CobaltCause/lemmy that referenced this issue Jun 14, 2023
Nutomic pushed a commit that referenced this issue Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: database enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants