Dont pass accept-encoding header to pictrs (ref #1734) #1738
Conversation
|
I pry wont be able to test this until sunday |
There was a problem hiding this comment.
Just tried this, it didn't work. I also added println's to make sure the headers were okay. You also used CONTENT_ENCODING here, not ACCEPT_ENCODING, both of which I tried to remove, and didn't work.
If you want to test this on your own, all you need to do is have a locally running nginx that looks identical to the one in the ansible folder, but use 1235 for the lemmy_ui_port and 8536 for the lemmy_port. Then do any picture upload, say in a comment box.
Also verified that the main branch does currently work, just to make sure.
|
If you have such an nginx setup working, could you add it to the repo in |
|
Mmmk that's here: #1765 |
Nutomic
force-pushed
the
pictrs-no-gzip
branch
from
0654dc2
to
625b959
Compare
|
Updated. Image uploads are working fine now without brotli/gzip deps. I had to rework #1765 a bit. |
| nginx: | ||
| image: nginx:1-alpine | ||
| ports: | ||
| - "1236:1236" |
There was a problem hiding this comment.
I wanted to use port 1234 here for consistency, but that wasnt working because image uploads were sent to localhost:8536 in that case, so the jwt cookie wasnt included. This is because of this overly complicated code in lemmy-ui, which seems somewhat broken.
https://github.com/LemmyNet/lemmy-ui/blob/main/src/shared/env.ts
| @@ -103,6 +106,7 @@ async fn image( | |||
| client: web::Data<Client>, | |||
| ) -> Result<HttpResponse, Error> { | |||
| let mut client_req = client.request_from(url, req.head()); | |||
| client_req.headers_mut().remove(ACCEPT_ENCODING); | |||
There was a problem hiding this comment.
I'll test this today. I coulda swore I tried and failed when doing this on my own system.
|
Works! |
I didnt manage to get image upload working locally, but based on
dbg!(&client_req.headers().keys())it removes the header as expected.