Feature add hours as sorting options backend #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2023
L3v3L
changed the title
L3v3L
changed the title
dessalines
approved these changes
Jun 17, 2023
|
|
||
| -- alter all you enum columns | ||
| alter table local_user | ||
| alter column default_sort_type type sort_type_enum using default_sort_type::text::sort_type_enum; |
There was a problem hiding this comment.
I did some searching and this does appear to be the correct way to do it, nice job.
| @@ -59,6 +59,9 @@ pub enum SortType { | |||
| TopAll, | |||
| MostComments, | |||
| NewComments, | |||
| TopHour, | |||
| TopSixHour, | |||
There was a problem hiding this comment.
Nice job. We did need to make sure these got appended, to make sure people's existing sort types didn't get wiped out.
|
Run |
ran, commited changes |
|
ready for merge |
Nutomic
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the possiblity to sort by Top Hour, Top Six Hours and Top Twelve Hours.
Related issue:
#3049
This PR is part of a 3 PRs:
Back End
#3161
Translation
LemmyNet/lemmy-translations#63
Front End
LemmyNet/lemmy-ui#1345