Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature add hours as sorting options frontend #1345

Merged
merged 15 commits into from
Jun 22, 2023
Merged

Feature add hours as sorting options frontend #1345

merged 15 commits into from
Jun 22, 2023

Conversation

L3v3L
Copy link
Contributor

@L3v3L L3v3L commented Jun 17, 2023 •
edited
Loading

This feature adds the possiblity to sort by Top Hour, Top Six Hours and Top Twelve Hours.

Related issue:
LemmyNet/lemmy#3049

This PR is part of a 4 PRs:

Back End
LemmyNet/lemmy#3161

Translation
LemmyNet/lemmy-translations#63

Front End
#1345

JS-Client
LemmyNet/lemmy-js-client#143

This was referenced Jun 17, 2023
Merged
Merged
@L3v3L L3v3L changed the title add hours as sorting options add hours as sorting options frontend Jun 17, 2023
@L3v3L L3v3L changed the title add hours as sorting options frontend feature add hours as sorting options frontend Jun 17, 2023
@L3v3L L3v3L changed the title feature add hours as sorting options frontend Feature add hours as sorting options frontend Jun 17, 2023
@L3v3L L3v3L marked this pull request as ready for review June 17, 2023 09:01
@dessalines dessalines closed this Jun 17, 2023
@dessalines dessalines reopened this Jun 17, 2023
dessalines
dessalines reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops sorry, I'll have to see the back-end PR first.

@L3v3L L3v3L marked this pull request as draft June 17, 2023 23:46
@L3v3L
Copy link
Contributor Author

L3v3L commented Jun 17, 2023 •
edited
Loading

I've moved this back to draft as other PR's need to be merged first before this can be merged

@c-andy-candies c-andy-candies mentioned this pull request Jun 20, 2023
Closed
@L3v3L L3v3L mentioned this pull request Jun 20, 2023
Merged
@L3v3L
Copy link
Contributor Author

L3v3L commented Jun 20, 2023

@dessalines this requires that this repo point to a new version of https://github.com/LemmyNet/lemmy-js-client, so that it includes LemmyNet/lemmy-js-client#143

@dessalines
Copy link
Member

Okay, a new lemmy-js-client is deployed at 0.18.0-rc.2 .

@dessalines
Copy link
Member

I'll have that merged shortly.

@L3v3L L3v3L marked this pull request as ready for review June 21, 2023 20:06
@L3v3L
Copy link
Contributor Author

L3v3L commented Jun 21, 2023

I don't think woodpecker errors are related to this PR

@L3v3L L3v3L marked this pull request as draft June 22, 2023 01:01
@L3v3L L3v3L marked this pull request as ready for review June 22, 2023 01:57
@L3v3L L3v3L requested a review from alectrocute as a code owner June 22, 2023 03:23
@L3v3L
Copy link
Contributor Author

L3v3L commented Jun 22, 2023

ready to be merged

alectrocute
alectrocute approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@alectrocute alectrocute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@SleeplessOne1917 SleeplessOne1917 merged commit 9cf09e8 into LemmyNet:main Jun 22, 2023
1 check passed
@Generator Generator mentioned this pull request Jun 28, 2023
Closed
@burakcan burakcan mentioned this pull request Jun 28, 2023
Closed
@L3v3L L3v3L mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@alectrocute alectrocute alectrocute approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@L3v3L @dessalines @SleeplessOne1917 @alectrocute