make activity channel infallible

[phiresky]

see #4288 (comment)

instead of ending the loop, log error and keep on going

[Nutomic]

I was just thinking that the problem might be somewhere in this new code. We should make an rc as soon as possible to see if its helping. But first clippy is complaining about unnecessary -> ()

[dessalines]

Just let me know and I can start an rc

[citking]

Applied 0.19.1-rc.1 to https://daring.lemmy.fan (bleeding edge federated sandbox instance) if you want me to test anything or if you want to sign up/in and test things.

Let me know if I can help in any other way. This instance was purposely-built for testing apps and Lemmy behavior on bleeding-edge releases.

[citking]

Following up - https://phiresky.github.io/lemmy-federation-state/site?domain=daring.lemmy.fan has been running 0.19.0-rc.1 for about 16 hours now and it seems happy with regards to federating. It could use some more activity to see if it continues to federate properly.

[Nutomic]

Note that the bug is not reflected on that federation state. Instead you can follow a remote community, if that goes through then federation is working in both directions.