Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing group from woodpecker, as its deprecated. #4387

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Jan 19, 2024

Also removing the drone meltwater cache. Half our builds fail because of its unreliability, and it probably doesn't save that much time anyway.

@Nutomic
Copy link
Member

Nutomic commented Jan 19, 2024

Now its going to run all the steps serially which is a waste of time. You need to add depends_on so that its parallel again. Basically check_api_common_default_features needs to depend on all the tasks from format group, and then remaining tasks below each need to depend on the previous task.

@dessalines
Copy link
Member Author

dessalines commented Jan 19, 2024

IMO its not worth the extra complication, because you'd have to add depends on to every single task after that, and the depends_on would need to be an array of all those tasks.

If you look at the build times, removing both group, and the meltwater cache, resulted in build times of less than a minute difference: https://woodpecker.join-lemmy.org/repos/129/pipeline/5112

Not only that, but the Rebuild Cache task is taking over 20m by itself.

@Nutomic Nutomic merged commit e78fe5a into main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants