Remove invalid XML characters from RSS feeds #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elara6331
requested review from
Nutomic,
dessalines and
phiresky
as code owners
Elara6331
changed the title
|
Is it correct to remove these characters or should they better be escaped/replaced? |
|
There's no way to represent these characters in valid XML, and they're not printable, so removing them won't affect any actual content. The post that broke the RSS reader in #4382 only contained them because it contained raw Java bytecode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any invalid XML characters from RSS strings based on the XML grammar definition for
Char, which is located here: https://www.w3.org/TR/xml/#NT-Char.I've tested this, and
xmllintsuccessfully parses the text from the post referenced in #4382 after it's sanitized by thesanitize_xml()function.Fixes #4382