Fixing docker release #4592
Fixing docker release #4592
Conversation
| @@ -94,7 +94,7 @@ pub async fn setup(context: LemmyContext) -> Result<(), LemmyError> { | |||
| delete_old_denied_users(&mut context.pool()).await; | |||
| update_instance_software(&mut context.pool(), context.client()) | |||
| .await | |||
| .inspect_err(|e| warn!("Failed to update instance software: {e}")) | |||
| .map_err(|e| warn!("Failed to update instance software: {e}")) | |||
There was a problem hiding this comment.
Had to get rid of all these .inspect, since they're actually only nightly / unstable.
There was a problem hiding this comment.
Nope it was stabilized in 1.76
https://doc.rust-lang.org/std/result/enum.Result.html#method.inspect_err
There was a problem hiding this comment.
That can't be right, or I'm missing something else: https://woodpecker.join-lemmy.org/repos/129/pipeline/6302/4#L2860
That's on rust:1.77
There was a problem hiding this comment.
Thats strange because Im developing with stable rust and never saw that error since 1.76. I also tried just now to build a release docker image locally, and it worked fine on both 1.76 and 1.77.
Ive restarted the build, lets see if that changes anything.
There was a problem hiding this comment.
Same failure again, weird. Gonna merge like this then.
dessalines
requested review from
Nutomic,
phiresky and
SleeplessOne1917
as code owners
Had to make a few changes to
.woodpecker.ymland one rust file to get a deploy working again.This is still failing on the crates publish, but at least the docker publish is fixed.